Allow zones to be properly imported #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, when zones are imported they don't have the `zone` attribute set inside the state. This causes the next plan to attempt to recreate the resource because it thinks the existing resource has an empty string for the zone attribute. The `zone` attribute is indeed set when zones are created through Terraform which explains why this may have gone unnoticed up until now.
ghost
added
the
jacobbednarz
approved these changes
Nov 19, 2018
|
Thanks Wesley! Great find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, when zones are imported they don't have the
zoneattribute set inside the state. This causes the next plan to attempt to
recreate the resource because it thinks the existing resource has an
empty string for the zone attribute. The
zoneattribute is indeed setwhen zones are created through Terraform which explains why this may
have gone unnoticed up until now.