validate logpush job name

[sbfaulkner]

when terraforming a cloudflare_logpush_job an invalid name attribute will successfully plan, but fail to apply

this PR adds validation using the appropriate regex so that it can be caught during plan instead

[github-actions]

changelog detected ✅

[github-actions]

This functionality has been released in v3.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[ChristophShyper]

@jacobbednarz @sbfaulkner Is this correct https://github.com/cloudflare/terraform-provider-cloudflare/pull/1717/files#diff-edc89067cd072336937f133d5ec6e811e3557e0670723f455231935a12cf0e0bR33 ?
It's ^[a-zA-Z0-9.-]+$, but shoduln't it be ^[a-zA-Z0-9.-]*$?
Because the new version started failing today:

│ Error: invalid value for name (must contain only alphanumeric characters, hyphens, and periods)
│ 
│   with module.logpush.cloudflare_logpush_job.this,
│   on ../submodule-cloudflare-logpush/main.tf line 25, in resource "cloudflare_logpush_job" "this":
│   25:   name                = ""
│ 
╵

It's another time this month when new release is breaking integration...

[jacobbednarz]

yep, regex should swap out those characters. if you send over a PR to address, I'll review in the morning.

[ChristophShyper]

Sure thing, here it is #1743

[sbfaulkner]

sorry about that - I didn't realize that name could be blank

[ChristophShyper]

When you create a logpush job from console page it's created without a name.
Or at least it's behaving like that when we imported it to Terraform.