Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access rules account_id support #1790

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Access rules account_id support #1790

merged 1 commit into from
Jul 20, 2022

Conversation

jacobbednarz
Copy link
Member

Allows explicit configuration of account level resources

@github-actions
Copy link
Contributor

changelog detected ✅

@jacobbednarz jacobbednarz force-pushed the access-rules-account-id-support branch from 105e408 to f4779de Compare July 20, 2022 04:54
@jacobbednarz
Copy link
Member Author

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessRule_" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareAccessRule_AccountASN
--- PASS: TestAccCloudflareAccessRule_AccountASN (14.45s)
=== RUN   TestAccCloudflareAccessRule_ZoneASN
--- PASS: TestAccCloudflareAccessRule_ZoneASN (19.54s)
=== RUN   TestAccCloudflareAccessRule_IPRange
--- PASS: TestAccCloudflareAccessRule_IPRange (15.29s)
=== RUN   TestAccCloudflareAccessRule_IPv6
--- PASS: TestAccCloudflareAccessRule_IPv6 (12.40s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   61.961s
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check   [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check      [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/version     [no test files]

@jacobbednarz jacobbednarz mentioned this pull request Jul 20, 2022
Closed
38 tasks
@jacobbednarz jacobbednarz merged commit 9dbdf8a into master Jul 20, 2022
@jacobbednarz jacobbednarz deleted the access-rules-account-id-support branch July 20, 2022 05:02
@github-actions github-actions bot added this to the v3.20.0 milestone Jul 20, 2022
github-actions bot pushed a commit that referenced this pull request Jul 20, 2022
Update CHANGELOG.md for #1790
93627ef
@jacobbednarz jacobbednarz restored the access-rules-account-id-support branch July 20, 2022 22:27
@github-actions
Copy link
Contributor

This functionality has been released in v3.20.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.20.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobbednarz