add cloudflare_api_shield resource #1874
Conversation
|
changelog detected ✅ |
jafowler
force-pushed
the
add-api-shield-resource
branch
from
ecff95d to
1eabea3
Compare
jafowler
force-pushed
the
add-api-shield-resource
branch
from
4ca8d61 to
223c334
Compare
|
v0.49.0 landed here yesterday; bumping your branch in case it was cut prior to the merge. |
| client := meta.(*cloudflare.API) | ||
| zoneID := d.Get("zone_id") | ||
|
|
||
| _, err := client.UpdateAPIShieldConfiguration(ctx, cloudflare.ZoneIdentifier(zoneID.(string)), cloudflare.UpdateAPIShieldParams{nil}) |
There was a problem hiding this comment.
this doesn't seem to be working. the payload is {"auth_id_characteristics":null} however, i'm unsure what it should be. could you find out? we may need to update the Go library if it is expecting no keys too.
There was a problem hiding this comment.
I followed up with the team:
we usually tend to preserve configurations and not delete them.
The endpoint currently has only one configuration value. To remove that one can send as the payload using PUT:
{"auth_id_characteristics":[]}
I will update the PR to send an empty auth_id_characteristics
|
acceptance tests are looking good! |
|
|
|
This functionality has been released in v3.23.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This PR requires [email protected] to merge. It will be angry until then. I'll wait for dependabot to do its thing then i'll rebase.