-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress session_duration diffs for bookmark applications #2076
Merged
jacobbednarz
merged 3 commits into
cloudflare:master
from
Justin-Holmes:jholmes/access-remove-default
Dec 9, 2022
Merged
Suppress session_duration diffs for bookmark applications #2076
jacobbednarz
merged 3 commits into
cloudflare:master
from
Justin-Holmes:jholmes/access-remove-default
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog detected ✅ |
jacobbednarz
requested changes
Dec 7, 2022
Justin-Holmes
force-pushed
the
jholmes/access-remove-default
branch
from
December 7, 2022 15:41
310c0cc
to
5e095a4
Compare
acceptance tests look good
|
This functionality has been released in v3.30.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where bookmark apps were always showing a diff for the session_duration field. We default that field to be '24h' when empty, however, bookmark apps don't have a session_duration so TF always showed a diff.