Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_spectrum_application: allow nesting of edge_ips #2219

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Feb 6, 2023

Updates the edge_ips from TypeSet to TypeList in order to allow nesting of ips, type and connectivity to match the API response.

Closes #1687

Updates the `edge_ips` from `TypeSet` to `TypeList` in order to allow
nesting of `ips`, `type` and `connecitivity` to match the API response.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member Author

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareSpectrumApplication_" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareSpectrumApplication_Basic
--- PASS: TestAccCloudflareSpectrumApplication_Basic (14.48s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginDNS
--- PASS: TestAccCloudflareSpectrumApplication_OriginDNS (11.99s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginPortRange
--- PASS: TestAccCloudflareSpectrumApplication_OriginPortRange (11.95s)
=== RUN   TestAccCloudflareSpectrumApplication_Update
--- PASS: TestAccCloudflareSpectrumApplication_Update (17.13s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPConnectivity
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPConnectivity (10.46s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPsWithoutConnectivity
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPsWithoutConnectivity (11.25s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPsMultiple
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPsMultiple (19.78s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	97.585s

@jacobbednarz jacobbednarz mentioned this pull request Feb 6, 2023
38 tasks
@jacobbednarz jacobbednarz force-pushed the spectrum-app-edge-redo branch from 8966c04 to 1dca4b2 Compare February 9, 2023 01:58
@jacobbednarz jacobbednarz force-pushed the spectrum-app-edge-redo branch from 1dca4b2 to 6dddaae Compare February 9, 2023 02:01
@jacobbednarz
Copy link
Member Author

tests still passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareSpectrumApplication_" -count 1 -parallel 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareSpectrumApplication_Basic
--- PASS: TestAccCloudflareSpectrumApplication_Basic (15.46s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginDNS
--- PASS: TestAccCloudflareSpectrumApplication_OriginDNS (12.94s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginPortRange
--- PASS: TestAccCloudflareSpectrumApplication_OriginPortRange (13.35s)
=== RUN   TestAccCloudflareSpectrumApplication_Update
--- PASS: TestAccCloudflareSpectrumApplication_Update (19.06s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPConnectivity
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPConnectivity (10.61s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPsMultiple
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPsMultiple (17.29s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	89.338s

@jacobbednarz jacobbednarz merged commit b9b4b64 into 4.x Feb 9, 2023
@jacobbednarz jacobbednarz deleted the spectrum-app-edge-redo branch February 9, 2023 23:07
@jacobbednarz jacobbednarz added this to the v4.0.0 milestone Feb 9, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.0.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant