Add new resource for dex tests #2250
Conversation
|
changelog detected ✅ |
|
|
||
| func testAccCloudflareDeviceDexTestsHttp(accountID, rnd string) string { | ||
| return fmt.Sprintf(` | ||
| resource "cloudflare_device_dex_tests" "%[1]s" { |
There was a problem hiding this comment.
these tests are all missing the required account_id field.
| func testAccCloudflareDeviceDexTestsHttp(accountID, rnd string) string { | ||
| return fmt.Sprintf(` | ||
| resource "cloudflare_device_dex_tests" "%[1]s" { | ||
| test_id = "%[2]s" |
There was a problem hiding this comment.
test_id doesn't appear in your schema. is this the value we are using for id? if so, we don't need it here.
There was a problem hiding this comment.
Yes for this resource we used test_id to represent what would usually be the id field. Thanks for the heads up.
|
acceptance tests all passing |
|
This functionality has been released in v4.3.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Must not be merged until the new
cloudflare-goversions have been published as it depends on fixes of dex_test feature of unreleasedcloudflare-go0.62.0 (https://github.com/cloudflare/cloudflare-go/blob/master/CHANGELOG.md) and the subsequent bugfix PR for it (cloudflare/cloudflare-go#1213)