Improve error handling in account delete function #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
therealdwright
force-pushed
the
improve-error-handling-in-accounts
branch
4 times, most recently
from
9b3acbd to
9f6fe19
Compare
therealdwright
force-pushed
the
improve-error-handling-in-accounts
branch
2 times, most recently
from
0da1d08 to
3401142
Compare
internal/sdkv2provider/resource_cloudflare_access_keys_configuration.go
Outdated
Show resolved
Hide resolved
therealdwright
force-pushed
the
improve-error-handling-in-accounts
branch
2 times, most recently
from
3401142 to
78895b2
Compare
This commit surfaces some additional information (the account ID) on account deletion failure cases. I encountered some strange behaviour (that ended up being my fault) that led to me digging through this module. Thought I'd leave it in a better place than I found it as I found a couple of minor issues. Closes cloudflare#2437
therealdwright
force-pushed
the
improve-error-handling-in-accounts
branch
from
78895b2 to
47a6814
Compare
therealdwright
changed the title
internal/sdkv2provider/resource_cloudflare_access_keys_configuration.go
Outdated
Show resolved
Hide resolved
|
thanks for following through on this one @therealdwright, appreciate it! |
|
This functionality has been released in v4.7.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit surfaces some additional information (the account ID) on account
deletion failure cases.
I encountered some strange behaviour (that ended up being my fault) that
led to me digging through this module. Thought I'd leave it in a better place than
I found it as I found a couple of minor issues.
Closes #2437