resource/cloudflare_tunnel_config: fix duration handling #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
handle-tunnel-duration-in-paylods
branch
from
638eb75 to
1937543
Compare
|
acceptance tests all passing HTTP payloads have also been manually verified as sending the seconds value. |
|
cc @obezuk |
|
changelog detected ✅ |
jacobbednarz
added
the
workflow/pending-upstream-library
This comment was marked as spam.
This comment was marked as spam.
Due to marshal/unmarshal support lacking in Go 1[1], we were previously sending nanosecond values to the API instead of the required seconds. This would have resulted in higher than usual timeout durations (10 seconds would have been sent as 1000000000 seconds since it duration unmarshals to nanoseconds). Updates all the instances of time duration handling in `cloudflare_tunnel_config` resource to use the newly introduced `TunnelDuration` to ensure we correctly setting the units. [1]: golang/go#10275
jacobbednarz
force-pushed
the
handle-tunnel-duration-in-paylods
branch
from
1937543 to
6423608
Compare
|
functional changes merged into #2541 to get CI green for version bumping |
|
This functionality has been released in v4.9.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to marshal/unmarshal support lacking for
time.Durationin Go 1, we were previously sending nanosecond values to the API instead of the required seconds. This would have resulted in higher than usual timeout durations (10 seconds would have been sent as 1000000000 seconds since it duration unmarshals to nanoseconds).Updates all the instances of time duration handling in
cloudflare_tunnel_configresource to use the newly introducedTunnelDurationto ensure we correctly setting the units.Depends on cloudflare/cloudflare-go#1303
Closes #2495