Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLP-1723: add ocr_enabled flag to DLP profiles #3224

Merged
merged 1 commit into from
Apr 18, 2024
Merged

DLP-1723: add ocr_enabled flag to DLP profiles #3224

merged 1 commit into from
Apr 18, 2024

Conversation

inanna-malick
Copy link

add support for newly-added ocr_enabled boolean flag in dlp profiles

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

changelog detected ✅

@inanna-malick
Copy link
Author

inanna-malick commented Apr 11, 2024 •
edited
Loading

Confirmed all DLP acceptance tests (including OCR enabled flag tests and DLP tests with no OCR flag) pass via TESTARGS='-run ".*DLP.*" -count 1 -parallel 1' make testacc

@inanna-malick
Copy link
Author

inanna-malick commented Apr 17, 2024 •
edited
Loading

squashed into single commit, confirmed all relevant acceptance tests still pass

@jacobbednarz
Copy link
Member

nice one! thanks

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDLPProfile_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDLPProfile_Custom
--- PASS: TestAccCloudflareDLPProfile_Custom (8.21s)
=== RUN   TestAccCloudflareDLPProfile_Custom_MultipleEntries
--- PASS: TestAccCloudflareDLPProfile_Custom_MultipleEntries (6.93s)
=== RUN   TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount
--- PASS: TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount (6.78s)
=== RUN   TestAccCloudflareDLPProfile_CustomWithOCREnabled
--- PASS: TestAccCloudflareDLPProfile_CustomWithOCREnabled (7.02s)
=== RUN   TestAccCloudflareDLPProfile_ContextAwareness
--- PASS: TestAccCloudflareDLPProfile_ContextAwareness (7.41s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	37.411s

@jacobbednarz jacobbednarz merged commit 7f9ff6a into cloudflare:master Apr 18, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.31.0 milestone Apr 18, 2024
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
Update CHANGELOG.md for #3224
86ba315
@inanna-malick inanna-malick deleted the inanna/DLP-1723 branch April 18, 2024 02:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

This functionality has been released in v4.31.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@inanna-malick @jacobbednarz