resource/resource_cloudflare_zone: add support for vanity_name_servers

[josip-stanic]

Adds support for setting vanity_name_servers in the cloudflare_zone resource.

[github-actions]

changelog detected ✅

[github-actions]

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

[josip-stanic]

Any feedback for this PR? Is there discussion needed?

[jacobbednarz]

no discussion/feedback for this one; it just hasn't been on my radar.

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareZone_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareZone_PreventZoneIdAndNameConflicts
=== PAUSE TestAccCloudflareZone_PreventZoneIdAndNameConflicts
=== RUN   TestAccCloudflareZone_NameLookup
=== PAUSE TestAccCloudflareZone_NameLookup
=== RUN   TestAccCloudflareZone_Basic
--- PASS: TestAccCloudflareZone_Basic (9.77s)
=== RUN   TestAccCloudflareZone_BasicWithJumpStartEnabled
--- PASS: TestAccCloudflareZone_BasicWithJumpStartEnabled (7.97s)
=== RUN   TestAccCloudflareZone_WithPlan
--- PASS: TestAccCloudflareZone_WithPlan (8.05s)
=== RUN   TestAccCloudflareZone_PartialSetup
--- PASS: TestAccCloudflareZone_PartialSetup (8.37s)
=== RUN   TestAccCloudflareZone_FullSetup
--- PASS: TestAccCloudflareZone_FullSetup (8.94s)
=== RUN   TestAccCloudflareZone_WithEnterprisePlan
--- PASS: TestAccCloudflareZone_WithEnterprisePlan (14.06s)
=== RUN   TestAccCloudflareZone_WithEnterprisePlanVanityNameServers
--- PASS: TestAccCloudflareZone_WithEnterprisePlanVanityNameServers (10.97s)
=== RUN   TestAccCloudflareZone_Secondary
--- PASS: TestAccCloudflareZone_Secondary (10.26s)
=== RUN   TestAccCloudflareZone_SecondaryWithVanityNameServers
--- PASS: TestAccCloudflareZone_SecondaryWithVanityNameServers (14.43s)
=== RUN   TestAccCloudflareZone_SetType
--- PASS: TestAccCloudflareZone_SetType (21.24s)
=== CONT  TestAccCloudflareZone_PreventZoneIdAndNameConflicts
--- PASS: TestAccCloudflareZone_PreventZoneIdAndNameConflicts (1.94s)
=== CONT  TestAccCloudflareZone_NameLookup
--- PASS: TestAccCloudflareZone_NameLookup (5.98s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	123.462s

thanks for the PR!

[github-actions]

This functionality has been released in v4.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!