Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access policies forcing new when no account id is set #3358

Merged

Conversation

GreenStage
Copy link
Contributor

This caused issues because it made tf diff policies that were not changed, and TF set those account ids to null. So it basically deleted the policies and failed to recreate them

@GreenStage GreenStage requested a review from jacobbednarz as a code owner June 17, 2024 15:32
Copy link
Contributor

github-actions bot commented Jun 17, 2024

changelog detected ✅

@GreenStage GreenStage force-pushed the egomes/fix-access-policy-force-new branch from 8aabe7a to dd83812 Compare June 19, 2024 10:52
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jul 11, 2024
@jacobbednarz jacobbednarz reopened this Aug 27, 2024
@jacobbednarz jacobbednarz merged commit 4708b62 into cloudflare:master Aug 27, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.41.0 milestone Aug 27, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

This functionality has been released in v4.41.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants