Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(3506): Fix list_item hostname overlap #3515

Merged

Conversation

patrick-vares-stash
Copy link
Contributor

@patrick-vares-stash patrick-vares-stash commented Jul 26, 2024

Closes #3506

Copy link
Contributor

github-actions bot commented Jul 26, 2024

changelog detected ✅

@patrick-vares-stash
Copy link
Contributor Author

I'm unfortunately not able to run the acceptance tests for this, but I tested it on my terraform and it worked as expected

@patrick-vares-stash patrick-vares-stash changed the title bug(3506): Fix list_tiem hostname overlap bug(3506): Fix list_item hostname overlap Jul 26, 2024
@jacobbednarz
Copy link
Member

acceptance tests all passing

=== RUN   TestAccCloudflareListItem_Basic
=== PAUSE TestAccCloudflareListItem_Basic
=== RUN   TestAccCloudflareListItem_MultipleItems
--- PASS: TestAccCloudflareListItem_MultipleItems (14.66s)
=== RUN   TestAccCloudflareListItem_Update
--- PASS: TestAccCloudflareListItem_Update (14.81s)
=== RUN   TestAccCloudflareListItem_BadListItemType
--- PASS: TestAccCloudflareListItem_BadListItemType (2.06s)
=== RUN   TestAccCloudflareListItem_ASN
--- PASS: TestAccCloudflareListItem_ASN (7.41s)
=== RUN   TestAccCloudflareListItem_Hostname
--- PASS: TestAccCloudflareListItem_Hostname (9.04s)
=== RUN   TestAccCloudflareListItem_Redirect
--- PASS: TestAccCloudflareListItem_Redirect (7.57s)
=== RUN   TestAccCloudflareListItem_RedirectWithOverlappingSourceURL
--- PASS: TestAccCloudflareListItem_RedirectWithOverlappingSourceURL (8.60s)
=== RUN   TestAccCloudflareListItem_WithOverlappingHostname
--- PASS: TestAccCloudflareListItem_WithOverlappingHostname (8.60s)
=== RUN   TestAccCloudflareListItem_IPWithOverlappingPrefix
--- PASS: TestAccCloudflareListItem_IPWithOverlappingPrefix (8.42s)
=== CONT  TestAccCloudflareListItem_Basic
--- PASS: TestAccCloudflareListItem_Basic (11.08s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/list_item	93.398s

@jacobbednarz jacobbednarz merged commit a831708 into cloudflare:master Jul 29, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.39.0 milestone Jul 29, 2024
@patrick-vares-stash patrick-vares-stash deleted the 3506-cloudflare_list_item branch July 29, 2024 13:12
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This functionality has been released in v4.39.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple cloudflare_list_item cannot be a substring of an existing entry on the list
2 participants