Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enabled_origin_commands field to waiting_room #3805

Merged

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Aug 28, 2024

Add support for enabled_origin_commands on the waiting_room resource.

This requires cloudflare-go v0.103.0 0

@broswen broswen requested a review from jacobbednarz as a code owner August 28, 2024 02:51
@broswen broswen force-pushed the bswenson/waiting-room-origin-commands branch from 1fd4de3 to 0e7eb4c Compare August 28, 2024 02:51
Copy link
Contributor

changelog detected ✅

Copy link
Contributor

This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately.

Please remove the changes to the go.mod or go.sum files from this PR in order to proceed with review and merging.

@broswen broswen force-pushed the bswenson/waiting-room-origin-commands branch from 0e7eb4c to 5e5b747 Compare August 28, 2024 02:54
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWaitingRoom_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWaitingRoom_Create
=== PAUSE TestAccCloudflareWaitingRoom_Create
=== CONT  TestAccCloudflareWaitingRoom_Create
--- PASS: TestAccCloudflareWaitingRoom_Create (4.36s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	4.983s

@jacobbednarz jacobbednarz merged commit bf5d7df into cloudflare:master Sep 2, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.41.0 milestone Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

This functionality has been released in v4.41.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants