Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Infrastructure Access Target and prefix with zero_trust #4403

Merged

Conversation

SaiDadireddy
Copy link
Contributor

@SaiDadireddy SaiDadireddy commented Oct 24, 2024

The purpose of this PR is to deprecate the existing cloudflare_infrastructure_access_target resource in favor of cloudflare_zero_trust_infrastructure_access_target as we want zero_trust prepended ahead of v5. This PR also deprecates the data source cloudflare_infrastructure_access_targets in favor of cloudflare_zero_trust_infrastructure_access_targets. Added new examples the new resource and datasource.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests looking good

$ TF_ACC=1 go test ./internal/framework/service/zero_trust_infrastructure_access_target/ -run "^TestAcc" -count 1 -v
=== RUN   TestAccCloudflareInfrastructureAccessTarget_DataSource
--- PASS: TestAccCloudflareInfrastructureAccessTarget_DataSource (3.36s)
=== RUN   TestAccCloudflareInfrastructureAccessTarget_Basic
--- PASS: TestAccCloudflareInfrastructureAccessTarget_Basic (2.86s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/zero_trust_infrastructure_access_target	6.908s

$ TF_ACC=1 go test ./internal/framework/service/infrastructure_access_target_deprecated/ -run "^TestAcc" -count 1 -v
=== RUN   TestAccCloudflareInfrastructureAccessTarget_DataSource
--- PASS: TestAccCloudflareInfrastructureAccessTarget_DataSource (2.65s)
=== RUN   TestAccCloudflareInfrastructureAccessTarget_Basic
--- PASS: TestAccCloudflareInfrastructureAccessTarget_Basic (2.83s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/infrastructure_access_target_deprecated	7.278s

@jacobbednarz jacobbednarz merged commit c477150 into cloudflare:master Oct 28, 2024
7 checks passed
@github-actions github-actions bot added this to the v4.45.0 milestone Oct 28, 2024
Copy link
Contributor

This functionality has been released in v4.45.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants