Added Priority field to cloudflare_zone_lockdown schema #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
…vider-cloudflare into zone-lockdown-priority
jacobbednarz
approved these changes
Aug 19, 2019
|
@mbrowne Just thinking about this, as the priority field is optional, we should add another test where this isn't present to exercise that code path. |
|
Ok, I added a test that passes only the required fields ( |
|
Awesome! Thanks @mbrowne! You rock 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZoneLockdown API has a
Priorityfield that was previously undocumented. They have since documented it, and I created a PR to add it to cloudflare-go, which was merged:cloudflare/cloudflare-go#266
This PR adds the Priority field to the
cloudflare_zone_lockdownresource in this provider.