resource/cloudflare_zone: No need to translate the ID to Name back to ID #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Within the `Update` we set the rate plan which requires the subscription ID mapped value[1]. We already have the legacy ID[2] so we don't need to pass it through the `planIDForName` method which we previously. I suspect this was a copy-paste issue from the `Read` method as we were also setting the `plan` value to the plan name which would haven't have been accepted in the schema anyway. This commit trims all of that out and just passes the ID as it should have always done. [1]: https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_zone.go#L35-L40 [2]: https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_zone.go#L18-L23 [3]: https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_zone.go#L81
jacobbednarz
force-pushed
the
dont-treat-an-id-as-name
branch
from
a8866cc to
37187d7
Compare
Turns out if you need to upgrade from a free plan to an enterprise plan, you need to create the subscription (using POST) not modify an existing one (PUT). Updates the call the `setRatePlan` to work out which HTTP verb to use based on the incoming plan ID change.
This isn't a huge deal but seeing how I'm touching this code, I can make it more efficient by only making the `setRatePlan` calls if we have changed the plan. Otherwise, pass over it.
patryk
approved these changes
Apr 28, 2020
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
…cache-purging add purge prefixes capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
Updatewe set the rate plan which requires thesubscription ID mapped value. We already have the legacy ID so we
don't need to pass it through the
planIDForNamemethod which wepreviously.
I suspect this was a copy-paste issue from the
Readmethod as wewere also setting the
planvalue to the plan name which wouldhaven't have been accepted in the schema anyway. In
addition to this, I've also updated the call to
setRatePlanto takeinto account whether or not the old plan was "free" which requires
a POST (not PUT) HTTP request to create a new subscription despite
the resource already existing.
Closes #667