Page rule additions v2 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`off` is an Enterprise feature, but I don't think it's the responsibility of the provider to know or care about a customer's contract with Cloudflare. The API should just Do The Right Thing if a user without appropriate permissions tries to use an invalid value.
Closed
|
Looks good, thanks Ross! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is take 2 of https://github.com/terraform-providers/terraform-provider-cloudflare/pull/68; that PR was in turn based off https://github.com/terraform-providers/terraform-provider-cloudflare/pull/61 and contained too many changes (some of which have since been merged).
It adds the following:
mirageactiondisable_railgunactionoffvalue forsecurity_levelactioncache_keystring fieldNote: I haven't written any tests because the existing test suite doesn't test each action and value. Happy to add tests that exercise the new functionality if you'd prefer.
Thanks for your consideration!
Ross