Fix to consider that a custom hostname fallback origin can move to active during a retry #818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been trying to use the new custom hostname fallback origin creation functionality of the provider and consistently hit the following error:
I traced the issue to the following condition:
The issue is that our custom hostname fallback origins from the https://api.cloudflare.com/#custom-hostname-fallback-origin-for-a-zone-properties API calls end up in the
active
state during the retry period. The retry logic didn't account for that state change and thus our custom domain fallback origin creation fails.