Add custom deny fields to Access application #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,6 +142,8 @@ func resourceCloudflareAccessApplicationCreate(d *schema.ResourceData, meta inte | |||
| SessionDuration: d.Get("session_duration").(string), | |||
| AutoRedirectToIdentity: d.Get("auto_redirect_to_identity").(bool), | |||
| EnableBindingCookie: d.Get("enable_binding_cookie").(bool), | |||
| CustomDenyMessage: d.Get("custom_deny_message").(string), | |||
There was a problem hiding this comment.
do we always want this appended to send zero values? or should we conditionally add it in?
There was a problem hiding this comment.
We don't want to append zero values. I'm using the omitempty tag on those fields https://github.com/Justin-Holmes/cloudflare-go/blob/justin/access_custom_deny_fields/access_application.go#L26-L27, so I believe they'll be omitted from the request.
Justin-Holmes
force-pushed
the
justin/custom-deny-fields
branch
from
6193e75 to
162a477
Compare
Justin-Holmes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a new cloudflare-go version with cloudflare/cloudflare-go#566 before this can be merged.