Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/access_group: pass group conditions via TransformAccessGroupForSchema #918

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Jan 22, 2021

Off the back of #917, this is another fix to ensure the state is able to be
compared against the remote API to correctly identify drift.

To be a good citizen, I've also swapped these d.Set calls to handle error
checking to prevent silent failures from slipping through.

Depends on #917
Fixes #891

…pForSchema`

Off the back of #917, this is another fix to ensure the state is able to be
compared against the remote API to correctly identify drift.

To be a good citizen, I've also swapped these `d.Set` calls to handle error
checking to prevent silent failures from slipping through.

Fixes #891
@jacobbednarz jacobbednarz force-pushed the run-access-group-through-transformer branch from ef63251 to f206a85 Compare January 28, 2021 00:19
@jacobbednarz jacobbednarz merged commit fdaf7b5 into master Jan 28, 2021
@jacobbednarz jacobbednarz deleted the run-access-group-through-transformer branch January 28, 2021 00:23
@jacobbednarz jacobbednarz added this to the 2.18.0 milestone Jan 28, 2021
@jacobbednarz jacobbednarz mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_group does not detect configuration drift
1 participant