Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature Request: wrangler.json support #2376

Closed
4 tasks
penalosa opened this issue Dec 9, 2022 · 0 comments · Fixed by #2409
Closed
4 tasks

🚀 Feature Request: wrangler.json support #2376

penalosa opened this issue Dec 9, 2022 · 0 comments · Fixed by #2409
Assignees
@penalosa
Labels
enhancement New feature or request quick win Potentially easy/straightforward issue to tackle

Comments

@penalosa
Copy link
Contributor

penalosa commented Dec 9, 2022 •
edited
Loading

Support wrangler.json as JSONC

  • Support reading wrangler.json wrangler.json should take precedence over wrangler.toml if present
  • Codemod: Write a codemod to transform wrangler.toml files to wrangler.(jsonc|json5|yaml) files. This could be published as (for example) @cloudflare/convert-wrangler-config, and run on your project with npx @cloudflare/convert-wrangler-config wrangler.toml (which would generate the file). Something that I think is quite important here: can we preserve config comments from the TOML files?
  • Documentation: We have a lot of mentions of wrangler.toml across our docs. They should all be updated to use wording like "Wrangler configuration file".
  • JSON Schema: Better typing of wrangler.json in IDEs
    Following up on The future of Wrangler configuration #1951 (comment)
@penalosa penalosa self-assigned this Dec 9, 2022
@penalosa penalosa added the quick win Potentially easy/straightforward issue to tackle label Dec 9, 2022
@lrapoport-cf lrapoport-cf moved this to Untriaged in workers-sdk Dec 9, 2022
@penalosa penalosa mentioned this issue Dec 14, 2022
Merged
6 tasks
@admah admah moved this from Untriaged to In Progress in workers-sdk Dec 21, 2022
@admah admah added the enhancement New feature or request label Dec 21, 2022
@github-project-automation github-project-automation bot moved this from In Progress to Done in workers-sdk Jan 23, 2023
@penalosa penalosa mentioned this issue Jan 23, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@penalosa penalosa

Labels
enhancement New feature or request quick win Potentially easy/straightforward issue to tackle
Projects
None yet
Milestone
No milestone
2 participants
@admah @penalosa