-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritise workerd
condition when bundling
#2629
Conversation
🦋 Changeset detectedLatest commit: fc3d4a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/4025095389/npm-package-wrangler-2629 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2629/npm-package-wrangler-2629 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/runs/4025095389/npm-package-wrangler-2629 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/runs/4025095389/npm-package-cloudflare-pages-shared-2629 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Codecov Report
@@ Coverage Diff @@
## main #2629 +/- ##
==========================================
+ Coverage 73.32% 73.35% +0.03%
==========================================
Files 159 159
Lines 9852 9852
Branches 2627 2627
==========================================
+ Hits 7224 7227 +3
+ Misses 2628 2625 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - personally I would prefer a bit more explanation in the changeset file, since this is what will appear in the changelog as documentation. For example you could add this sentence from the PR description:
This can be used to implement isomorphic libraries that work with different JavaScript runtimes. workerd is the standard key for the Cloudflare Workers runtime: https://runtime-keys.proposal.wintercg.org/#workerd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! What about adding an e2e test, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
What this PR solves / how to test:
This PR adds support for the
workerd
condition when bundling Worker code. This can be used to implement isomorphic libraries that work with different JavaScript runtimes.workerd
is the standard key for the Cloudflare Workers runtime: https://runtime-keys.proposal.wintercg.org/#workerd.To test this PR, run
npx wrangler dev
in thefixtures/worker-app
directory, and visit http://127.0.0.1:8787/random in your browser. Note that random data appears. We haven't enabled Node.js compatibility so we must be using theworkerd
version of theisomorphic-random-example
package.Associated docs issues/PR:
Author has included the following, where applicable:
Reviewer has performed the following, where applicable: