fix wrangler publish --dry-run to not require authentication with queues #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a9d2d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/4025332909/npm-package-wrangler-2631You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2631/npm-package-wrangler-2631Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/runs/4025332909/npm-package-wrangler-2631 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/runs/4025332909/npm-package-cloudflare-pages-shared-2631 |
rozenmd
reviewed
Jan 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
- Coverage 73.32% 73.32% -0.01%
==========================================
Files 159 159
Lines 9852 9848 -4
Branches 2627 2626 -1
==========================================
- Hits 7224 7221 -3
+ Misses 2628 2627 -1
|
When wrangler configuration has queues, wrangler publish dry-run requires the user to be logged in. This is not the expected behavior. This originates from wrangler publish ensuring that configured queues actually exists on the user account. This should not be a concern for dry-run. This commit fixes this.
done |
|
thanks @rozenmd. Anything special to merge the change? It seems I don't have permission to do this. |
|
Oh sorry about that, merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrangler configuration has queues, wrangler publish dry-run requires the user to be logged in.
This is not the expected behavior.
This originates from wrangler publish ensuring that configured queues actually exists on the user account.
This should not be a concern for dry-run. This commit fixes this.
What this PR solves / how to test:
Associated docs issues/PR:
Author has included the following, where applicable:
- [ ] TestsReviewer has performed the following, where applicable:
- [ ] Checked for inclusion of relevant tests- [ ] Checked for creation of associated docs updatesFixes #2630 .