Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support darwin golang; allow any golang version [fixes #80, fixes #36] #81

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Jun 28, 2019

This PR helpfully adds mac/darwin support to the CPI bosh create-env command. It also makes it very easy to upgrade to new golang versions in future by only replacing the blobs (no changes required to the packages/golang/ files).

To test this PR:

First, add a darwin golang to blobs (and let's upgrade to 1.12.6 whilst we're at it; but please can we move to a public blobstore too? #77)

mkdir -p tmp
curl https://dl.google.com/go/go1.12.6.linux-amd64.tar.gz -o tmp/go1.12.6.linux-amd64.tar.gz
curl https://dl.google.com/go/go1.12.6.darwin-amd64.tar.gz -o tmp/go1.12.6.darwin-amd64.tar.gz
bosh add-blob tmp/go1.12.6.linux-amd64.tar.gz go1.12.6.linux-amd64.tar.gz
bosh add-blob tmp/go1.12.6.darwin-amd64.tar.gz go1.12.6.darwin-amd64.tar.gz

Next, create a dev release:

bosh create-release --version 22.0.$(date -u "+%Y%m%d%H%M%S") --tarball tmp/bosh-alicloud-cpi-release.tgz --force

An example operator file for a bosh create-env command is:

- type: replace
  path: /releases/-
  value:
    name: bosh-alicloud-cpi
    version: latest
    url: file:///path/to/bosh-alicloud-cpi-release/tmp/bosh-alicloud-cpi-release.tgz

Then apply the operator to your bosh create-env command.

@cfdreddbot
Copy link

✅ Hey drnic! The commit authors and yourself have already signed the CLA.

@drnic
Copy link
Contributor Author

drnic commented Jun 30, 2019

I've cut a release of this PR at https://github.com/drnic/bosh-alicloud-cpi-release/releases/tag/22.0.1

@drnic
Copy link
Contributor Author

drnic commented Jul 2, 2019

cc @xiaozhu36 could you please review/merge this PR for next release? thanks!

@xiaozhu36 xiaozhu36 merged commit a0ca680 into cloudfoundry:master Jul 9, 2019
@drnic drnic deleted the darwin-golang branch July 9, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants