Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**CLI** user should NOT see a **diff** when **removing routes** #2200

Closed
sethboyles opened this issue Apr 19, 2021 · 2 comments
Closed

**CLI** user should NOT see a **diff** when **removing routes** #2200

sethboyles opened this issue Apr 19, 2021 · 2 comments

Comments

@sethboyles
Copy link
Member

Context

Removing routes from a manifest does not unmap them from the app or delete the route. Showing routes removed from the manifest in the diff can confuse people into thinking the routes will be unmapped and/or deleted.


Acceptance Criteria

Omit Route Removals

Given an app named my-app
And it is mapped to two routes one.example.com and two.example.com
When I apply the following manifest

---
applications:
  - name: my-app
    routes:
      - route: two.example.com

Then the route one.example.com should not show up as being removed in the diff


Notes:

  • The manifest diff endpoint should not return route deletions, so this logic can be shared across all clients
@sethboyles
Copy link
Member Author

@sweinstein22 sweinstein22 added this to the manifest-diffs milestone May 6, 2021
@sethboyles
Copy link
Member Author

seems to have been fixed as part of cloudfoundry/routing-release#200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants