Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::CompositeIO & ::Parts deprecation warnings #2985

Closed
samcolson4 opened this issue Sep 27, 2022 · 2 comments
Closed

::CompositeIO & ::Parts deprecation warnings #2985

samcolson4 opened this issue Sep 27, 2022 · 2 comments

Comments

@samcolson4
Copy link
Contributor

Issue

When running unit tests, several deprecation warnings appear:

Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!

Steps to Reproduce

Run unit tests:
bundle exec rake spec:all spec/unit/middleware/rate_limiter_v2_api_spec.rb

Expected result

No deprecation warnings should be shown.

Current result

Deprecation warnings are shown, as above.

Possible Fix

The faraday-multipart dependency on multipart-post is known to be a common cause. This gem has been updated to a new version which could be used.

@will-gant
Copy link
Contributor

Had a bit of a delve into this, but haven't had a chance to try fixes yet.

The two warnings are emitted (here and here) by versions above 2.2.0 of the gem multipart-post. We're consuming v2.2.3.

multipart-post is a child dependency of v0.17.5 of faraday, and it looks to me like the first version of that which won't suffer from this is going to be v2.0.0, which actually removed multipart-post entirely as a dependency. This is roughly how we're consuming multipart-post at the moment:

  • multipart-post 2.2.3
    • faraday 0.17.5
      • faraday_middleware 0.14.0
        • azure-core 0.1.15
          • azure-stoage (fork based on v1.1.0)
            • fog-azure-rm (a special branch for CF: fog-arm-cf)

@philippthun
Copy link
Member

Fixed with #3259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants