Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Component: Show loading indicator before initialised$ fires #2302

Closed
richard-cox opened this issue Jun 8, 2018 · 0 comments · Fixed by #2412
Closed

List Component: Show loading indicator before initialised$ fires #2302

richard-cox opened this issue Jun 8, 2018 · 0 comments · Fixed by #2412
Assignees
Labels
P1 Priority 1

Comments

@richard-cox
Copy link
Contributor

richard-cox commented Jun 8, 2018

  • Users table blocks on initialised - which is 6 calls to fetch roles for connected user
  • Progress indicator only shows once initialised fires
  • This leads to pretty poor ux
  • Simple fix to move non-list header loading indicator out of ngif initialised block
  • requires new obs to switch from initialised to obs that need data source

Myself and @KlapTrap agree this is a simple, quick change that will really improve the experience on the three users tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants