Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmos should warn if not on latest version #263

Closed
osterman opened this issue Nov 23, 2022 · 4 comments · Fixed by #809
Closed

Atmos should warn if not on latest version #263

osterman opened this issue Nov 23, 2022 · 4 comments · Fixed by #809
Labels
enhancement New feature or request

Comments

@osterman
Copy link
Member

what

  • Emit a warning to STDERR that an out-of-date version of atmos is in use
  • Support a atmos.yaml configuration setting to specify a list acceptable semver ranges
  • Use the https://api.github.com/repos/cloudposse/atmos/releases API to determine the latest release satisfying semver ranges

why

Atmos is under active development. Bugs are constantly fixed. Older versions cause grief that could be avoided by upgrading.

example

versions:
- '~> 1.4'
- '! 1.4.2'
atmos version
1.4.1
atmos terraform plan...
WARNING: Latest version of atmos is 1.4.2; you're using atmos 1.4.1
...
@osterman osterman added the enhancement New feature or request label Nov 23, 2022
@osterman
Copy link
Member Author

image

@aknysh
Copy link
Member

aknysh commented Feb 22, 2023

updating to the latest version breaks all the scrolling on the site.
We'll have to review all of that and prob add/update some CSS before updating.

(this is usually happens with Node, React and other JS frameworks - too many dependencies, too many people involved, they can't test everything, so in my experience, it almost always breaks one thing or another)

@osterman
Copy link
Member Author

updating to the latest version breaks all the scrolling on the site.

To be clear, I'm not talking about docusarus, but atmos itself should emit a dialog like this if there's a newer version available.

@llpham14
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants