Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate redundant tags_enabled input #81

Closed
nitrocode opened this issue Nov 26, 2024 · 0 comments · Fixed by #82
Closed

Deprecate redundant tags_enabled input #81

nitrocode opened this issue Nov 26, 2024 · 0 comments · Fixed by #82
Labels
bug 🐛 An issue with the system good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nitrocode
Copy link
Member

Describe the Bug

See #44 (comment)

I know this is an old change. I was reviewing this from git blame because i was surprised we need a tags_enabled var when the tags var can be set to null or an empty map {}. The original change is in the referenced PR and the inclusion of managed policies is in this PR.

If the tags var can be used to disable tagging, can we consider deprecating tags_enabled var?

I pinged the original author and approver and we all agreed that this input is no longer needed.

Expected Behavior

See above

Steps to Reproduce

See above

Screenshots

See above

Environment

No response

Additional Context

No response

@nitrocode nitrocode added the bug 🐛 An issue with the system label Nov 26, 2024
@Gowiem Gowiem added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants