Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 7.3 #11

Open
ocean90 opened this issue Feb 12, 2019 · 2 comments
Open

Add support for PHP 7.3 #11

ocean90 opened this issue Feb 12, 2019 · 2 comments
Assignees
@ivomarino

Comments

@ocean90
Copy link
Contributor

ocean90 commented Feb 12, 2019

See http://php.net/supported-versions.php.

One thing that needs an update is https://github.com/ttssdev/appflow-playbooks/blob/45d95a9345c804f8551fac9f8a669468ca2a13c8/roles/web/tasks/php.yml#L52 because mcrypt is moved out of PHP for PHP 7.2+.
@ivomarino ivomarino self-assigned this Apr 14, 2020
@ivomarino
Copy link
Member

vars/os/distribution_release/Ubuntu-bionic.yml:conf_php_version_debian_family: 7.2 defaults to 7.2 actually, for 7.3 just override this value in the tenant settings.

@ivomarino ivomarino reopened this Apr 29, 2020
@ivomarino
Copy link
Member

See http://php.net/supported-versions.php.

One thing that needs an update is

https://github.com/ttssdev/appflow-playbooks/blob/45d95a9345c804f8551fac9f8a669468ca2a13c8/roles/web/tasks/php.yml#L52

because mcrypt is moved out of PHP for PHP 7.2+.

this needs to be put in a when condition like: skip if conf_php_version_debian_family > 7.2

@ivomarino ivomarino changed the title Add support for PHP 7.2 and 7.3 Add support for 7.3 Apr 29, 2020
@ivomarino ivomarino changed the title Add support for 7.3 Add support for PHP 7.3 Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivomarino ivomarino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocean90 @ivomarino