Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.4 and update test environment #25

Merged
merged 1 commit into from
Dec 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ on:
jobs:
PHPUnit:
name: PHPUnit (PHP ${{ matrix.php }})
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
matrix:
php:
- 8.4
- 8.3
- 8.2
- 8.1
Expand Down Expand Up @@ -38,7 +39,7 @@ jobs:

PHPUnit-hhvm:
name: PHPUnit (HHVM)
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
continue-on-error: true
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ composer install
To run the test suite, go to the project root and run:

```bash
php vendor/bin/phpunit
vendor/bin/phpunit
```

## License
Expand Down
20 changes: 10 additions & 10 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@
"email": "[email protected]"
}
],
"autoload": {
"psr-4": {
"Clue\\React\\Multicast\\": "src/"
}
},
"autoload-dev": {
"psr-4": {
"Clue\\Tests\\React\\Multicast\\": "tests/"
}
},
"require": {
"php": ">=5.3",
"react/datagram": "^1.10",
Expand All @@ -31,5 +21,15 @@
},
"suggest": {
"ext-sockets": "Requires PHP 5.4+ and the low level socket API for listening on multicast addresses (socket options to send IGMP announcements)"
},
"autoload": {
"psr-4": {
"Clue\\React\\Multicast\\": "src/"
}
},
"autoload-dev": {
"psr-4": {
"Clue\\Tests\\React\\Multicast\\": "tests/"
}
}
}
7 changes: 1 addition & 6 deletions src/Factory.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@ class Factory
* This value SHOULD NOT be given unless you're sure you want to explicitly use a
* given event loop instance.
*
* ```php
* $loop = React\EventLoop\Factory::create();
* $factory = new Factory($loop);
* ```
*
* @param LoopInterface $loop
* @param ?LoopInterface $loop
*/
public function __construct($loop = null)
{
Expand Down