Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-blocking output for stdout #47

Closed
WyriHaximus opened this issue Jun 24, 2017 · 4 comments · Fixed by #68
Closed

Use non-blocking output for stdout #47

WyriHaximus opened this issue Jun 24, 2017 · 4 comments · Fixed by #68

Comments

@WyriHaximus
Copy link

Went through the source and came across https://github.com/clue/php-stdio-react/blob/0c9a7fe7a87643499c56dc5af63c3e497b717d79/src/Stdout.php#L11 noting STDOUT is used in a blocking manner. Is there anything special that needs to be done, or can be be wrapped into a WritableResourceStream and hooked into the loop easily?

@clue
Copy link
Owner

clue commented Jun 24, 2017

I suppose this is related to #6, but we'd have to look into this. Do you feel like filing a PR? 👍

For the reference: The WritableResourceStream didn't exist back when this repo has been created and part of the motivation for creating that class was actually for this repo :shipit:

@WyriHaximus
Copy link
Author

Do you feel like filing a PR?

Working on https://github.com/wyrihaximus/reactphp-psr-3-stdio so yeah I'm up for filing a PR 😀 .

For the reference: The WritableResourceStream didn't exist back when this repo has been created and part of the motivation for creating that class was actually for this repo :shipit:

I'm aware, found out that file it from 2014 no worries 👍

@WyriHaximus
Copy link
Author

WyriHaximus commented Jul 7, 2017

Note that the two referenced PR's are in I've started working on this 🎉

@WyriHaximus
Copy link
Author

Interesting enough my current local code closes STDOUT and cuts phpunit output 🤐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants