Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-line params don't override config #65

Closed
qrkourier opened this issue Mar 27, 2022 · 4 comments
Closed

command-line params don't override config #65

qrkourier opened this issue Mar 27, 2022 · 4 comments

Comments

@qrkourier
Copy link
Contributor

This works correctly:

# overrides config
$ mycli --myopt myarg

This does not override

# config overrides command-line
$ mycli --myopt=myarg

The only difference seems to be whether space-sep or =-sep'd opt=arg syntax is used. I'm investigating and will update this issue if I find the cause.

@qrkourier
Copy link
Contributor Author

 ❯ pip show milc
Name: milc
Version: 1.6.5
Summary: Opinionated Batteries-Included Python 3 CLI Framework.
Home-page: https://milc.clueboard.co/
Author: skullydazed
Author-email: [email protected]
License: MIT License
Location: /home/kbingham/.pyenv/versions/3.9.0/lib/python3.9/site-packages
Requires: appdirs, argcomplete, colorama, halo, spinners
Required-by: netfoundry

@skullydazed
Copy link
Collaborator

Thanks for the report! I've fixed it in c901c3b, can you give that a try? If that works for you I'll cut a new release.

@qrkourier
Copy link
Contributor Author

qrkourier commented Mar 27, 2022

Wow! Thank you so much. That was quick, and it's encouraging to see the batteries are still included with MILC. This is the first CLI framework I've worked with and it's been a pleasure.

Confirmed. With that rev I am able to override the general config with either space or equal sep'd command-line params.

@skullydazed
Copy link
Collaborator

Glad to hear it! I've released 1.6.6 with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants