Fix handling of "-jX" short style flag with argument #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the implementation becomes more complicated, it's better not to repeat it.
Before, _index_arg (and _in_argv) would not function correctly in this case. This change makes the recently added tests pass and closes clueboard#69.
|
This PR has been idle for 6 months and will be closed in 2 months if the stale lable is not removed. |
|
Hi, is there anything I can do to move this forward? |
|
Hey there, apologies for not responding for so long. Every time I come back to this I want to fix it, but this particular approach leads to some confusing results if you try to combine short style flags in other ways, EG using |
|
That's fine, I added that info to #69 and I'll close this up. Thanks for getting back to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #69.