More typing

[elpekenin]

I have just noticed i missed these on my first PR... Sorry about the extra noise

Note that the _question implementation is a bit hacky, but seems to work completely fine with mypy :)

[elpekenin]

Just realized args and kwargs can probably be annotated as P.args and P.kwargs, will test and report back tomorrow

[elpekenin]

Aight, it doesn't seem to work... But i see that sparkline's typing is broken, im taking a look at that

[skullydazed]

I just added an ignore for that, it's mypy getting picky about a variable that's only used internally to the function. If you rebase it should be working now.

[elpekenin]

Just in case, this is ready for review/merge on my end

[elpekenin]

Oops, seems like mypy didn't like

# stub
@overload
def question():

def _question(): 

# implementation is not next to the stub
def question()

So... im thinking about ordering like:

• overloads
• question
• _question

[skullydazed]

I think that can work, it still bundles the code at the end.

If you can't find a way that works with code at the end, we can settle for what does work.

[skullydazed]

Looks like the latest commit passes. Ready to merge?

[elpekenin]

Yeah!

[skullydazed]

Thanks!