Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong info about config/ConEmu.xml #1152

Closed
borekb opened this issue Nov 6, 2016 · 5 comments
Closed

Wrong info about config/ConEmu.xml #1152

borekb opened this issue Nov 6, 2016 · 5 comments

Comments

@borekb
Copy link

borekb commented Nov 6, 2016

If I'm reading things correctly, since #600 the ConEmu conflig is loaded from vendor/conemu-maximus5/ConEmu.xml, not config/ConEmu.xml. The config README might be incorrect: https://github.com/cmderdev/cmder/blame/master/config/Readme.md#L14

If someone confirms this, I'll be happy to submit a PR to fix this.

Also related: #695

@daxgames
Copy link
Member

daxgames commented Nov 6, 2016

ConEmu conflig is loaded from vendor/conemu-maximus5/ConEmu.xml, not config/ConEmu.xml on an existing install.

On a fresh install where cmder has never run the conemu.xml is copied from config/ConEmu.xml to vendor/conemu-maximus5/ConEmu.xml them conemu is launched and loads the config from vendor/conemu-maximus5/ConEmu.xml all changes via conemu gui are stored here.

-- start unreleased functionality

The currently unreleased cmder.exe will on an existing install copy vendor/conemu-maximus5/ConEmu.xml to config/user-conemu.xml at launch to maintain a 'copy' of the current conemu config. So as you make changes via conemu gui they are backed up so they are not lost upon deletion of the vendor/conemu folder.

On a new install/update if vendor/conemu-maximus5/ConEmu.xml does not exist and config/user-conemu.xml does then config/user-conemu.xml will be copied to vendor/conemu-maximus5/ConEmu.xml and used instead of config/conemu.xml.

The above makes it safe to delete the entire vendor folder and not lose any user config assuming you are not going in an manually editing scripts in this folder.

-- end unreleased functionality

Hopefully this makes sense.

@borekb
Copy link
Author

borekb commented Nov 6, 2016

Great explanation, thanks. If I were to open a PR for config/README.md, should it be against the master or development branch?

@daxgames
Copy link
Member

daxgames commented Nov 6, 2016

At this time you could do either. I think we are still trying to decide which.

@daxgames
Copy link
Member

daxgames commented Nov 6, 2016

Master is where the new config I spoke of above is located.

@Stanzilla Stanzilla reopened this Dec 1, 2016
@Stanzilla
Copy link
Member

@borekb @daxgames one of you making a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants