-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how we check for git directories in cmder.lua #786
Comments
@vladimir-kotikov Yeah, should cut down on the time to find a .git folder. |
Actually, the rebase hints and the info if I'm behind the remote are also nice... :-) |
It would be great if this will improve perfomance, but i recall that we've been relying on git already at some moment before #438 and there were some perf issues... Unfortunately, git on Windows is not so super-fast as on Nix machines :( |
Made some timings, and the results are not very promising (the timings are in 1/100 sec, measurements are made for directories, placed on SSD):
So IMO it's better to keep the current approach. Personally for me it's not very comfortable to wait ~0.5 sec each time before thr prompt updates. Here is the gist with git_prompt_filter function, that uses |
@vladimir-kotikov Can you tell how you did the timing? That would make a nice test how to evaluate changes to this functions... :-) Or was that just the printouts? |
Just printouts, exactly the same as in the gist |
@DRSDavidSoft @daxgames this is no longer needed, right? we already sped that up? |
I don't fully know the context of this issue, since the original line has changed |
See https://github.com/git/git/blob/master/contrib/completion/git-prompt.sh#L362
The text was updated successfully, but these errors were encountered: