Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher is not recognized as a valid Win32 application on windows XP. #96

Closed
samvasko opened this issue Dec 24, 2013 · 28 comments
Closed
Assignees
Milestone

Comments

@samvasko
Copy link
Contributor

No description provided.

@chKarner
Copy link

I managed to build a working launcher for XP by setting the Platform Toolset to the Windows XP version (v120_xp).

Also RegDelTree is not supported on Windows XP. (I removed UnregisterShellMenu() as a quick/dirty fix.)

Hope this helps.

@samvasko
Copy link
Contributor Author

Thanks! I did not really made the launcher. I think @austinwagner was the one. And I am not really familiar with C++ and Windows Api that much.
So if you could possibly do the mentioned changes without having to remove that function. You can just submit a pull and I am happy to accept it! 👍

@ghost ghost assigned MartiUK Jan 10, 2014
@isimmons
Copy link

Just ran into this issue. Trying to get one portable dev toolset to use across XP, Vista, and 7. Also PHP 5.5 needs msvcr110.dll instead of msvcr120.dll which comes with cmder. Gonna check and see if it's as simple as dropping the additional 110 versions of the dlls in there but thought I'd mention it.

Will this need to have a separate launcher for XP or are you guys working on one that will work for all? I wish I could help but I don't know much about C++ and the Win API or creating launchers either.

@MartiUK
Copy link
Member

MartiUK commented Jan 19, 2014

I've got some changes to be pushed to the xplauncher branch. In currently figuring out how to build specifically for xp .etc

@isimmons
Copy link

Nice :-) As for the PHP issue I mentioned, dropping the correct dll into my vendor/php directory does fix that problem so it's non cmder issue.

@ghost ghost assigned MartiUK Jan 21, 2014
@MartiUK
Copy link
Member

MartiUK commented Jan 21, 2014

For everyone who's affected by this please try the xplauncher branch.

@perlun
Copy link

perlun commented Feb 17, 2014

Hi @MartiUK, where is this branch? I couldn't find it on the main page for the repo - has it been merged into master?

@MartiUK
Copy link
Member

MartiUK commented Feb 17, 2014

@perlun it's currently in the development branch

@perlun
Copy link

perlun commented Feb 17, 2014

OK, thanks. I guess there's no binary available for this one? It would be cool to try it out, and I'm unfortunately using an older XP machine for the time being.. 😄

I guess it's perhaps not that hard to compile from source though?

@MartiUK
Copy link
Member

MartiUK commented Feb 17, 2014

I've used Visual C++ 2013 Express to build it and it was fine.

@benavern
Copy link

the version in the developpement branch doesn't work for me, on windows xp...

Is there something special to do before executing the .exe ?

@MartiUK
Copy link
Member

MartiUK commented Feb 17, 2014

@benavern Did you compile it under DebugXP or ReleaseXP configuration?

@benavern
Copy link

no, I did nothing, just downloaded the zip file of that branch and tried to execute it.
I don't have any tool like those you mentionned. Sorry I'm just a user of cmder but not a dev... I would just like to use it at work for ruby on rails developpement. is there something else that is as pretty as that one ? :p

@MartiUK
Copy link
Member

MartiUK commented Feb 17, 2014

@benavern Right sorry, I can try and get a pre-pre-XP Release up tonight (UK time) but I would prefer to not have any more binary files in the repo. And keep them only in releases.

@benavern
Copy link

ok, it would be nice ! (UK time is the same as mine, I'm in france at the moment ;) )
Thank you very much, I look forward to see that working on this old computer at work !

@MartiUK
Copy link
Member

MartiUK commented Feb 17, 2014

@benavern Done, check the releases. Let me know how it goes.

@benavern
Copy link

OK, thanks a lot, I'll try it tomorrow morning at work ;)

@benavern
Copy link

it seems to be working well! thank you very well!

@isimmons
Copy link

Just tried it too. Working great. Thank you!

@MartiUK
Copy link
Member

MartiUK commented Feb 24, 2014

Thanks for testing it out, I will close this issue as this will be in the next release. 👍

@MartiUK MartiUK closed this as completed Feb 24, 2014
@dbkaplun
Copy link

Hmm... still having this issue. I tried 1.1.4.1 and 1.1.3 with no success.

@vfiset
Copy link

vfiset commented Mar 17, 2015

@secrettriangle same here, did you find any workaround?

@dbkaplun
Copy link

No :/

@vfiset
Copy link

vfiset commented Mar 17, 2015

Hi @Bliker, I am experiencing the same issue with v1.1.4.1. Is there something I am missing? edit: I am on xp (unfortunately for me)

@MartiUK
Copy link
Member

MartiUK commented Mar 18, 2015

@secrettriangle @vfiset Your problems should be fixed now: 5dbb84d

@vfiset
Copy link

vfiset commented Mar 20, 2015

Thanks for caring! how can I build the dev branch? I am imcompetant when it comes to windows stuff. I don't see any hints in the doc.

@Jackbennett
Copy link
Contributor

Run powershell.exe and cd into cmder/scripts and get-help .\build.ps1 -full should tell you plenty.

@Jackbennett
Copy link
Contributor

or use get-help .\build.ps1 -detailed would be a more appropriate amount of output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants