-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Ellipsoid Class, use fixed bonds. #191
Open
chrisjonesBSU
wants to merge
17
commits into
cmelab:main
Choose a base branch
from
chrisjonesBSU:new-ellipsoids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+234
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 94.77% 92.08% -2.69%
==========================================
Files 26 26
Lines 1970 2048 +78
==========================================
+ Hits 1867 1886 +19
- Misses 103 162 +59
|
Yeah I'm noticing the same thing..so we'll probably have to use rigid bodies still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ellipsoid chain features currently in flowerMD are quite "experimental", and after doing a deeper dive with @StephMcCallum there are clearly some issues with the approach we used initially (rigid bodies + ghost particles) that make the model unstable and difficult to get up and running.
After chatting a bit, we think it would be worth revamping these classes in flowerMD to start with a more simple approach. The model here now uses fixed bond lengths between the tips of 2 bonded ellipsoids. A single ghost particle is used between ellipsoids that will handle both fixed bonds, and enforcing a 2-body angle potential (ellipsoid_center - ghost at tip- ellipsoid_center). Rigid bodies are no longer used in this approach.
Here is a minimal example: