-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASAN] heap-buffer-overflow in L1TrackerEtMissEmulatorProducer #41320
Comments
assign l1, upgrade |
New categories assigned: upgrade,l1 @epalencia,@AdrianoDee,@srimanob,@aloeliger,@cecilecaillol you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
In the earlier ASAN IB (CMSSW_13_1 2023-04-07-2300) the workflow succeeded. None of the PRs merged between two look like immediately clear culprit though. |
@makortel If I needed to recreate this error, what's the best way to go about it? |
@aloeliger on lxplus or cmsdev:
|
Interestingly the report did not get reproduced in CMSSW_13_1_ASAN_X_2023-04-12-2300 |
Sorry, I finally had some time to look at this today. I can get @iarspider's instructions to run all the way through. Looking at the original output, should I be running this through valgrind or something similar to catch this issue? |
No, the Address Sanitizer is linked within the binaries in the ASAN build, and nothing special needs to be done to run them. The error has not reproduced in IBs either. It could be that there is some rare non-reproducibility in play. |
I mean, as best I can understand the ASAN (address sanitizer? This is new to me. At the risk of sounding like I don't have a clue I'd be curious to hear or read more) stack trace output, the primary complaint is that I looked that up and actually found two different implementations. I think the primary intended one in this scenario is this one: cmssw/L1Trigger/L1TTrackMatch/src/L1TkEtMissEmuAlgo.cc Lines 6 to 16 in e01b0cd
Which returns a If you look at where the cosLUT value is used, this is the primary use case: cmssw/L1Trigger/L1TTrackMatch/plugins/L1TrackerEtMissEmulatorProducer.cc Lines 184 to 226 in 5b979f2
But this doesn't seem like it would have any non-deterministic problem in it. I'm also not seeing an obvious |
Another occurrence in CMSSW_13_1_ASAN_X_2023-04-24-2300
|
Another occurrence in CMSSW_13_2_ASAN_X_2023-05-17-2300
|
Another occurrence in CMSSW_13_2_X_2023-05-22-2300:
|
Another occurrence in CMSSW_13_2_ASAN_X_2023-05-24-2300:
|
@aperloff @Chriisbrown You are both listed as authors on |
Another occurrence in CMSSW_13_2_ASAN_X_2023-06-09-2300 workflow 23834.999 step 3
|
ASAN reports in CMSSW_13_1_ASAN_X_2023-04-10-2300 workflow 23834.999 step 3
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc11/CMSSW_13_1_ASAN_X_2023-04-10-2300/pyRelValMatrixLogs/run/23834.999_TTbar_14TeV+2026D95PU_PMXS1S2PR/step3_TTbar_14TeV+2026D95PU_PMXS1S2PR.log#/
The text was updated successfully, but these errors were encountered: