-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production job failed because of incorrect locale settings #46850
Comments
assign core |
New categories assigned: core @Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
cms-bot internal usage |
A new Issue was created by @makortel. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
@smuzaffar Do we have anything about locales in our containers? For example, I see (via |
@makortel , for el8 and el9 we installed Instead of rebuilding |
My feeling (without diving deeply into intricacies of locales) is that could be a good idea. Or maybe setting Would the scram hook apply "immediately" to all jobs? |
we can set both
yes, it will apply to all jobs when they setup cmssw env |
cms-sw/cmsdist#9554 adds the new scram runtime site-hook which sets |
cms-sw/cmsdist#9554 is ready but we will deploy it on Monday |
I ran a full |
can you please confirm whether we need a new release for this, or the cmssw container updated automatically and deployed for production ? |
@vlimant , there is no need of new release. scram site hook has been deployed on CVMFS and should be automatically picked up by production jobs |
I think we can then close the issue |
+core |
This issue is fully signed and ready to be closed. |
https://its.cern.ch/jira/browse/CMSPROD-226 shows production job failures (on 16_0_43) caused by incorrect locale settings. Already scram warns
and then later an exception
is thrown from
cmssw/GeneratorInterface/EvtGenInterface/plugins/EvtGen/EvtGenInterface.cc
Line 367 in 7fe6de8
(that was run via
ExternalGeneratorFilter
).The error is reproducible locally (in
cmssw-el7
container) e.g. by settingLC_ALL=C.UTF-8
before runningcmsRun
.I assume we could have also other code that could fail when the locale is set to an incorrect value. I wonder how CMS applications should behave if locale is being set incorrectly. On one hand it feels an invalid locale feels a bit silly reason to fail a job, but on the other hand, how much can we trust on string interpretation if the locale is invalid? Furthermore, I think we have been rather ignorant on locale settings so far, and in any case in the production use case all strings (e.g. job configuration) originate from somewhere else than the worker node (i.e. if we'd really want to handle locales properly, we'd have to propagate the locale from wherever e.g. the configuration file is created; or something).
Should we perhaps enforce some locale in all scram environments?
The text was updated successfully, but these errors were encountered: