Replace Geometry_cff with GeometryDB_cff in EgammaAnalysis

[jeongeun]

PR description:
Review on the Reco part of #31113

process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, EgammaAnalysis configuration files (2 files) are fixed.

EgammaAnalysis/ElectronTools/test/run_RegressionAndCombination_cfg.py
EgammaAnalysis/ElectronTools/test/run_exampleMva_cfg.py

PR validation:

Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39092/31608

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• EgammaAnalysis/ElectronTools (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

@cms-sw/egamma-pog-l2 : these test configs are definitely old and certainly not used since a while. If they are not needed any more a better oprion could be removing them at all, rather than spending time in maintaining them every some while. Please let us know.

[swagata87]

Hello @perrotta

indeed it looks like they are obsolete and can be removed.
However, before removing anything from egamma related packages, we generally announce it in egamma cmsTalk; wait about 1 week or so for people to react/give their opinion, and only after that we delete stuff.

if it's ok for you then please have this PR on hold for a week or so, while we check with rest of the egamma group that everyone is fine with deleting these 2 files. I will get back to you here.

[perrotta]

Thank you @swagata87 : yes, that's perfectly fine, this is certainly not an urgent PR
@jeongeun please be ready to remove the obsolete configs instead of fixing them, if and when @cms-sw/egamma-pog-l2 will confirm approving it

[swagata87]

Hi,
We have not received any objection[1] from egamma group about removing the following two files[2]. So they can be safely removed.

[1]https://cms-talk.web.cern.ch/t/removal-of-obsolete-files-from-egammaanalysis-electrontools-package/14033

[2]https://github.com/cms-sw/cmssw/blob/master/EgammaAnalysis/ElectronTools/test/run_exampleMva_cfg.py and https://github.com/cms-sw/cmssw/blob/master/EgammaAnalysis/ElectronTools/test/run_RegressionAndCombination_cfg.py

[perrotta]

@jeongeun could you please go ahead with the suggestion from @swagata87 in #39092 (comment) and fully remove the two test files?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39092/31907

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #39092 was updated. @cmsbuild can you please check and sign again.

[perrotta]

please test

[perrotta]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f436cb/27318/summary.html
COMMIT: decff2d
CMSSW: CMSSW_12_6_X_2022-09-04-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39092/27318/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log
• 138.2138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618210
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618175
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[perrotta]

merge
Failing tests are untelated