Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cnabio/cnab-to-oci
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.5
Choose a base ref
...
head repository: cnabio/cnab-to-oci
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.6
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 2, 2022

  1. Match insecure registry behavior from Docker

    This tweaks how we create a resolver so that we handle plain http
    connections, and TLS validation the same way as Docker.
    
    * When a loopback address is specified as insecure, that should take
      precedence over it being plain http. So if I'm running a local
      registry with self-signed certificates, it should use the skipTLS http
      client, and not attempt to use plain http.
    * All loopback addresses, not just localhost and 127.0.0.1, should
      default to plain http unless specified as insecure.
    
    The impact is that you only need to specify that a registry is insecure
    when:
    
    * You used self-signed certificates
    * It uses plain http on a non-loopback address
    
    When I was looking at the docker library we are using to create a
    resolver, I saw that we were using deprecated functionality. By using
    the Hosts function that is called per registry to determine how to
    connect to that registry, I was able to simplify the resolver and not
    need to create 3 separate resolvers.
    
    Signed-off-by: Carolyn Van Slyck <[email protected]>
    carolynvs committed Aug 2, 2022

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    mjcarroll Michael Carroll
    Copy the full SHA
    fcdf2c4 View commit details

Commits on Aug 3, 2022

  1. Merge pull request #127 from carolynvs/fix-skip-tls

    Match insecure registry behavior from Docker
    carolynvs authored Aug 3, 2022

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    mjcarroll Michael Carroll
    Copy the full SHA
    1cae69f View commit details
Loading