-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy demo #230
Comments
Hi @holl- thanks for the comment. The goal of Contextualized is to recover context-dependent models from data. The "Death to Cluster Models" demo digs a little deeper than the demo you mention, and directly compares Contextualized regression against SKLearn regression and simple PyTorch neural networks applied to the same problem. In general though, traditional statistical models do not account for context-dependent parameters and cannot generalize to new contexts. Neural networks are also insufficient on their own, and do not explicitly reveal a context-specific data distribution. Contextualized models recover context-specific models and generalize to new contexts. Thanks for the catch about |
@cnellington Right, the other notebook is more detailed. However, the way your documentation is set up, most people will first look at the easy demo. It would be very helpful if there were some more comments explaining what is going on and linking to further documentation. |
@holl- I believe the documentation ordering and the descriptions for motivation and use are addressed by the recent PR above. Let us know if you have any other comments. |
@cnellington Thanks for the update! I think it's a big step in the right direction. Before I close the Issue, could you add the appropate documentation links to the
|
+1 from me, as a beginner, when I started trying the tutorials and reading the documentation. Actually, one of my first questions was: why not use a neural network with the context as features (+shap). |
@holl- @pescap Two recent changes on
Let me know if there is anything else you'd like us to address, but I believe this addresses all outstanding comments. |
Looks good to me 👍 |
I'm trying to understand your easy demo but am having some trouble. Could you please add more documentation to explain what the code is doing? For example, clearly state your problem in the beginning. What variables are we actually interested in?
Could you also highlight why using your library is easier than doing this with Scikit learn or PyTorch or similar libraries? Couldn't I just pass (C,X) to a regular model and train it in supervised fashion? What does your library do that I couldn't easily achieve otherwise?
You introduce ε in the equation but I don't see this implemented in the code. The other variables are not explained either.
The text was updated successfully, but these errors were encountered: