Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: enable beforeAfterValidator in randomized tests #134158

Closed
rharding6373 opened this issue Nov 3, 2024 · 2 comments
Closed

cdc: enable beforeAfterValidator in randomized tests #134158

rharding6373 opened this issue Nov 3, 2024 · 2 comments
Assignees
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented Nov 3, 2024

The beforeAfterValidator is an important validator for changefeeds because it tests that emitted messages match the contents of the original tables at their mvcc timestamp. However, the validator today supports only limited data types, since it currently determines whether a row existed or not by creating a SQL query filtered on all fields in the emitted message, but does so inaccurately for some types (e.g., arrays, geo types). Therefore it doesn't work out of the box for randomized testing, which produces tables with all valid database types.

Jira issue: CRDB-43943

@rharding6373 rharding6373 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Nov 3, 2024
Copy link

blathers-crl bot commented Nov 3, 2024

cc @cockroachdb/cdc

@wenyihu6
Copy link
Contributor

Closed by #136003.

@wenyihu6 wenyihu6 self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Development

No branches or pull requests

2 participants