sql/tests: TestRandomSyntaxGeneration failed [ALTER TENANT (SELECT 'foo') START REPLICATION ... immediately crashes the database process]

[cockroach-teamcity]

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-24.1.8-rc @ 8450f1eef817abf295de10517cf0720e65e7a9b0:

=== RUN   TestRandomSyntaxGeneration
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/d437d2c847dfedbc4972f231c3331c8e/logTestRandomSyntaxGeneration2502463685
    test_log_scope.go:76: use -show-logs to present logs inline
    rsg_test.go:935: 5s of 5m0s: 9760 executions, 558 successful
    rsg_test.go:935: 10s of 5m0s: 21155 executions, 1101 successful
    rsg_test.go:935: 15s of 5m0s: 34833 executions, 1702 successful
    rsg_test.go:935: 20s of 5m0s: 43155 executions, 2109 successful
    rsg_test.go:935: 25s of 5m0s: 56014 executions, 2670 successful
    rsg_test.go:935: 30s of 5m0s: 67844 executions, 3204 successful
    rsg_test.go:935: 35s of 5m0s: 80535 executions, 3758 successful
    rsg_test.go:935: 40s of 5m0s: 93937 executions, 4323 successful
    rsg_test.go:935: 45s of 5m0s: 102242 executions, 4678 successful
    rsg_test.go:935: 50s of 5m0s: 112587 executions, 5142 successful
    rsg_test.go:935: 55s of 5m0s: 123125 executions, 5605 successful
    rsg_test.go:935: 1m0s of 5m0s: 133247 executions, 6025 successful
    rsg_test.go:935: 1m5s of 5m0s: 142224 executions, 6389 successful
    rsg_test.go:935: 1m10s of 5m0s: 151196 executions, 6772 successful
    rsg_test.go:935: 1m15s of 5m0s: 160231 executions, 7173 successful
    rsg_test.go:935: 1m20s of 5m0s: 170546 executions, 7574 successful
    rsg_test.go:935: 1m25s of 5m0s: 181363 executions, 7975 successful
    rsg_test.go:935: 1m30s of 5m0s: 191338 executions, 8403 successful
panic: ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr?

goroutine 1322947 [running]:
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.typeAnnotation.assertTyped(...)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:148
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Subquery).TypeCheck(0x42dd58?, {0x10?, 0x10?}, 0xc005048bd8?, 0x1900000000430d65?)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_check.go:1730 +0xd3
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.TypeCheck({0x820d5f0?, 0xc0053ac1e0?}, {0x820e428?, 0xc01f85d950?}, 0x6932652?, 0xc0001ca570?)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_check.go:335 +0x8a
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.TypeCheckAndRequire({0x820d5f0?, 0xc0053ac1e0?}, {0x820e428?, 0xc01f85d950?}, 0x8?, 0xbe2d800, {0x69f09ab, 0x21})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_check.go:345 +0x54
github.com/cockroachdb/cockroach/pkg/sql.(*planner).analyzeExpr(0xc006f10688, {0x820d5f0, 0xc0053ac1e0}, {0x820e428?, 0xc01f85d950?}, {{0x0, 0x0, 0x0}, {0x0, 0x0}}, ...)
	github.com/cockroachdb/cockroach/pkg/sql/analyze_expr.go:34 +0xaf
github.com/cockroachdb/cockroach/pkg/sql.(*planner).planTenantSpec(0xc0053ac1e0?, {0x820d5f0?, 0xc0053ac1e0?}, 0xc00000001e?, {0x69f09ab?, 0xc01d6ab038?})
	github.com/cockroachdb/cockroach/pkg/sql/tenant_spec.go:63 +0x190
github.com/cockroachdb/cockroach/pkg/sql.(*planner).LookupTenantInfo(0xc006f10688, {0x820d5f0, 0xc0053ac1e0}, 0x81ec770?, {0x69f09ab?, 0x0?})
	github.com/cockroachdb/cockroach/pkg/sql/tenant_spec.go:148 +0x27
github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest.alterReplicationJobHook.func1({0x820d5f0, 0xc0053ac1e0}, {0x820d5f0?, 0xc01f85d530?, 0xf0f000006a0210b?}, 0xc0202792c0)
	github.com/cockroachdb/cockroach/pkg/ccl/streamingccl/streamingest/alter_replication_job.go:205 +0x150
github.com/cockroachdb/cockroach/pkg/sql.(*hookFnNode).startExec.func1()
	github.com/cockroachdb/cockroach/pkg/sql/planhook.go:201 +0xa3
created by github.com/cockroachdb/cockroach/pkg/sql.(*hookFnNode).startExec in goroutine 1321295
	github.com/cockroachdb/cockroach/pkg/sql/planhook.go:199 +0x185

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

• sql/tests: TestRandomSyntaxGeneration failed [ALTER TENANT (SELECT 'foo') START REPLICATION ... immediately crashes the database process] #136274 sql/tests: TestRandomSyntaxGeneration failed [ALTER TENANT (SELECT 'foo') START REPLICATION ... immediately crashes the database process] [A-disaster-recovery C-test-failure O-robot T-disaster-recovery branch-release-24.3 release-blocker]
• sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting] #132558 sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting] [C-test-failure O-robot P-2 T-db-server branch-release-24.1.6-rc]

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-45309

[blathers-crl]

cc @cockroachdb/disaster-recovery

[msbutler]

fixed on release branch