sql/tests: TestRandomSyntaxGeneration failed [nil pointer dereference in backupPlanHook]

[cockroach-teamcity]

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-23.1.30-rc @ 2ee70ad63870ea3b44cb8593d0ac84d379547fc6:

    rsg_test.go:922: 2m50s of 5m0s: 377982 executions, 16863 successful
    rsg_test.go:922: 2m55s of 5m0s: 388584 executions, 17290 successful
    rsg_test.go:922: 3m0s of 5m0s: 398155 executions, 17688 successful
    rsg_test.go:922: 3m5s of 5m0s: 407692 executions, 18074 successful
    rsg_test.go:922: 3m10s of 5m0s: 417048 executions, 18465 successful
    rsg_test.go:922: 3m15s of 5m0s: 425238 executions, 18815 successful
    rsg_test.go:922: 3m20s of 5m0s: 434885 executions, 19216 successful
    rsg_test.go:922: 3m25s of 5m0s: 444932 executions, 19601 successful
    rsg_test.go:922: 3m30s of 5m0s: 455268 executions, 20017 successful
    rsg_test.go:922: 3m35s of 5m0s: 462998 executions, 20345 successful
    rsg_test.go:922: 3m40s of 5m0s: 470461 executions, 20650 successful
    rsg_test.go:922: 3m45s of 5m0s: 480428 executions, 21027 successful
    rsg_test.go:922: 3m50s of 5m0s: 493524 executions, 21628 successful
    rsg_test.go:922: 3m55s of 5m0s: 507384 executions, 22210 successful
    rsg_test.go:922: 4m0s of 5m0s: 520206 executions, 22807 successful
    rsg_test.go:922: 4m5s of 5m0s: 533608 executions, 23437 successful
    rsg_test.go:922: 4m10s of 5m0s: 544824 executions, 23923 successful
    rsg_test.go:922: 4m15s of 5m0s: 557548 executions, 24511 successful
    rsg_test.go:922: 4m20s of 5m0s: 570204 executions, 25050 successful
    rsg_test.go:922: 4m25s of 5m0s: 583199 executions, 25642 successful
    rsg_test.go:922: 4m30s of 5m0s: 595808 executions, 26238 successful
    rsg_test.go:922: 4m35s of 5m0s: 607688 executions, 26822 successful
    rsg_test.go:922: 4m40s of 5m0s: 620401 executions, 27400 successful
    rsg_test.go:922: 4m45s of 5m0s: 632569 executions, 27965 successful
    rsg_test.go:922: 4m50s of 5m0s: 644848 executions, 28508 successful
    rsg_test.go:922: 4m55s of 5m0s: 656942 executions, 29061 successful
    rsg_test.go:243: Context cancelled while executing: "BACKUP TO PLACEHOLDER INCREMENTAL FROM PLACEHOLDER , 'string' WITH REVISION_HISTORY , INCLUDE_ALL_VIRTUAL_CLUSTERS"
    rsg_test.go:243: Context cancelled while executing: "CREATE DATABASE IF NOT EXISTS ident"
    rsg_test.go:243: Context cancelled while executing: "CREATE STATISTICS POLYGON ON CONNECTION , BOX2D , OUT , DECIMAL , PRECISION FROM [ 265 ]"
    rsg_test.go:243: Context cancelled while executing: "CREATE DATABASE IF NOT EXISTS ident"
    rsg_test.go:243: Context cancelled while executing: "CREATE DATABASE IF NOT EXISTS ident"
    rsg_test.go:243: Context cancelled while executing: "PREPARE BOOLEAN ( DEFERRED . ident ARRAY [ -168 ] ) AS OPT PLAN 'string'"
    rsg_test.go:243: Context cancelled while executing: "CREATE DATABASE IF NOT EXISTS ident"
    rsg_test.go:243: Context cancelled while executing: "RESTORE SYSTEM USERS FROM PLACEHOLDER IN ( PLACEHOLDER ) , PLACEHOLDER , ( PLACEHOLDER , PLACEHOLDER , PLACEHOLDER ) WITH OPTIONS ( VERIFY_BACKUP_TABLE_DATA )"
    rsg_test.go:243: Context cancelled while executing: "CREATE DATABASE IF NOT EXISTS ident"
    rsg_test.go:243: Context cancelled while executing: "CREATE DATABASE IF NOT EXISTS ident"
    rsg_test.go:243: Context cancelled while executing: "FETCH RELATIVE - -53 STRING"
    rsg_test.go:243: Context cancelled while executing: "REFRESH MATERIALIZED VIEW STRING . RELATIVE . MATERIALIZED WITH DATA"
    rsg_test.go:243: Context cancelled while executing: "ROLLBACK TRANSACTION TO SAVEPOINT EXPERIMENTAL_FINGERPRINTS"
    rsg_test.go:958: 667800 executions, 29573 successful
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x46dc456]

goroutine 3894650 [running]:
github.com/cockroachdb/cockroach/pkg/ccl/backupccl.backupPlanHook.func1({0x75387e0, 0xc02a4561b0}, {0x0?, 0x0?, 0x0?}, 0xc03a97ac00?)
	github.com/cockroachdb/cockroach/pkg/ccl/backupccl/backup_planning.go:898 +0x1a56
github.com/cockroachdb/cockroach/pkg/sql.(*hookFnNode).startExec.func1()
	github.com/cockroachdb/cockroach/pkg/sql/planhook.go:200 +0xa4
created by github.com/cockroachdb/cockroach/pkg/sql.(*hookFnNode).startExec
	github.com/cockroachdb/cockroach/pkg/sql/planhook.go:198 +0x1b2

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

• sql/tests: TestRandomSyntaxGeneration failed [unexpected statement: *tree.RollbackPrepared] #137325 sql/tests: TestRandomSyntaxGeneration failed [C-test-failure O-robot T-sql-foundations branch-master release-blocker]
• sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting] #132558 sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting] [C-test-failure O-robot P-2 T-db-server branch-release-24.1.6-rc]

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-45599

[spilchen]

The nil dereference is here:

cockroach/pkg/ccl/backupccl/backup_planning.go

Line 898 in 2ee70ad

p.InternalSQLTxn().Descriptors().ReleaseAll(ctx)

[blathers-crl]

cc @cockroachdb/disaster-recovery

[msbutler]

Uses deprecrated backup syntax. closing.

BACKUP TO PLACEHOLDER INCREMENTAL FROM PLACEHOLDER , 'string' WITH REVISION_HISTORY , INCLUDE_ALL_VIRTUAL_CLUSTERS