Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: push down columns to update within a column family. #30656

Closed
andreimatei opened this issue Sep 26, 2018 · 3 comments
Closed

storage: push down columns to update within a column family. #30656

andreimatei opened this issue Sep 26, 2018 · 3 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. no-issue-activity X-stale

Comments

@andreimatei
Copy link
Contributor

Currently, updates to some columns in a column family is implemented by reading the whole column family (in fact, all the col fams until #18168 is fixed) in order to compute the value for the col fam. But we shouldn't need to read anything; kv should be able to decode the columns sufficiently so that it can only overwrite the intended columns.
We should be careful to always update the timestamp cache narrowly so that updates to a non-overlapping set of columns contend as little as possible.

@andreimatei andreimatei added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. labels Sep 26, 2018
@andreimatei
Copy link
Contributor Author

Extracted morally from #20080 which talks more generally about pushing down various types of computation.

@andreimatei
Copy link
Contributor Author

Actually I guess for blind writes the timestamp cache is not updated, so I was talking nonsense about it above.

@github-actions
Copy link

github-actions bot commented Jun 5, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) C-performance Perf of queries or internals. Solution not expected to change functional behavior. no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

1 participant