Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella #68970

Closed
filipecosta90 opened this issue Aug 16, 2021 · 5 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-community Originated from the community T-storage Storage Team

Comments

@filipecosta90
Copy link

filipecosta90 commented Aug 16, 2021

Problem

The codahale/hdrhistogram repo has been transferred under the github HdrHstogram umbrella with the help from the original author in Sept 2020 (new repo url https://github.com/HdrHistogram/hdrhistogram-go). The main reasons are to group all implementations under the same roof and to provide more active contribution from the community as the original repository was archived several years ago.

The dependency URL should be modified to point to the new repository URL. The tag "v0.9.0" was applied at the point of transfer and will reflect the exact code that was frozen in the original repository.

If you are using Go modules, you can update to the exact point of transfer using the @v0.9.0 tag in your go get command.

go mod edit -replace github.com/codahale/hdrhistogram=github.com/HdrHistogram/[email protected]

Performance Improvements

From the point of transfer, up until now (mon 16 aug 2021), we've released 3 versions that aim support the standard HdrHistogram serialization/exposition formats, and deeply improve READ performance.
We recommend to update to the latest version.

Jira issue: CRDB-9388

@blathers-crl
Copy link

blathers-crl bot commented Aug 16, 2021

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Aug 16, 2021
@RichardJCai RichardJCai added T-dev-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) and removed X-blathers-untriaged blathers was unable to find an owner labels Aug 16, 2021
@RichardJCai
Copy link
Contributor

Not entirely sure who to assign this do, putting on the dev infrastructure radar for now.

@jlinder
Copy link
Collaborator

jlinder commented Aug 24, 2021

What part of cockroach uses this dependency? I'd suggest that the team who owns that code would be the team that takes this.

@jlinder
Copy link
Collaborator

jlinder commented Aug 24, 2021

It looks like pebble uses this. So then the storage team.

@blathers-crl blathers-crl bot added the T-storage Storage Team label Aug 24, 2021
@jlinder jlinder removed the T-dev-inf label Aug 24, 2021
@nicktrav
Copy link
Collaborator

nicktrav commented Jun 1, 2022

Closed via cockroachdb/pebble#1715.

@nicktrav nicktrav closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-community Originated from the community T-storage Storage Team
Projects
None yet
Development

No branches or pull requests

4 participants